fix Issue 9788 - -profile doesn't work if exceptions are thrown in the r... #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e running program
| @@ -913,27 +913,42 @@ void FuncDeclaration::toObjFile(int multiobj) | |||
| bx.module = getModule(); | |||
| irs.blx = &bx; | |||
|
|
|||
| /* If profiling, insert call to the profiler here. | |||
| * _c_trace_pro(char* funcname); | |||
| /* Doing this in semantic3() caused all kinds of problems: | |||
There was a problem hiding this comment.
You may want to link this very pull request to illustrate the previous state of affairs: #1806
andralex
added a commit
that referenced
this pull request
Mar 31, 2013
fix Issue 9788 - -profile doesn't work if exceptions are thrown in the r...
andralex
added a commit
that referenced
this pull request
Mar 31, 2013
fix Issue 9788 - -profile doesn't work if exceptions are thrown in the r...
| se->type = se->type->semantic(0, NULL); | ||
| Expressions *exps = new Expressions(); | ||
| exps->push(se); | ||
| FuncDeclaration *fdpro = FuncDeclaration::genCfunc(Type::tvoid, "trace_pro"); |
There was a problem hiding this comment.
Why isn't this _c_trace_pro any longer?
There was a problem hiding this comment.
To not break existing binaries. If I broke existing binaries, then using git bisect will fail. I try to keep the binary API the same at least from one release to the next.
There was a problem hiding this comment.
I appreciate this and usually try the same, but you missed that goal already because _c_trace_epi is also new.
dlang/druntime@7b162ff
|
This pull request introduced a regression: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...unning program
fix http://d.puremagic.com/issues/show_bug.cgi?id=9788