9921: Enum variables of type void should be illegal #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If enum has no members but still has a base type, eg enum X : BaseType; we still need to run semantic on the memtype BaseType.
If the base type isn't valid, don't calculate enum.max
WalterBright
added a commit
that referenced
this pull request
Apr 18, 2013
9921: Enum variables of type void should be illegal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sounds like a trivial accepts-invalid bug, but the fix is necessary for my CTFE refactoring.
The important part of this pull request is to avoid calculating min and max for an enum with an erroneous base type, because in that case it was sending garbage to the CTFE engine.