Remove undefined behavior from test23. #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you cast but not dereference instead of killing those old tests? |
|
The bug being tested is bug 407, and it was a DMD segfault. Perhaps this undefined behaviour could be detected in the front-end? Maybe worth opening a new bug report for that. |
|
@klickverbot |
The code tried to load 4 bytes from an 1-3 byte allocation. LLVM's optimizer actually detects this, marking the entire result undefined.
|
Added a reference to the Bugzilla issue. @yebblies: It's probably not valid under a straightforward interpretation of the C memory model (may only access memory from the allocation a pointer is based on). |
yebblies
added a commit
that referenced
this pull request
May 7, 2013
Remove undefined behavior from test23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code tried to load 4 bytes from an 1-3 byte allocation.
LLVM's optimizer actually detects this, marking the entire
result undefined.