Issue 10658 - Cannot merge template overload set by using alias declaration #2417
Conversation
|
Few hours ago #2401 was merged and I rebased commits onto master. Now this change contains just only essential changes. |
|
LGTM, but does it allow to merge function overload sets and template overload sets? |
| s->parent = sc->parent; | ||
| } | ||
| } | ||
| else if (OverDeclaration *od = sa->isOverDeclaration()) |
There was a problem hiding this comment.
This block is virtually the same as the one before it. I hope they don't go out of sync one day.
There was a problem hiding this comment.
Essentially yes. In the future I'd like to improve the code to handle overloadings, but today it is necessary.
I'm also interested in this. Otherwise this pull gets a LGTM as well. It's great to see this finally fixed. |
…eclaration - Add OverDeclaration and see it in overloadApply. - Use OverDeclaration for template overload set merging. - Check OverDeclaration in DotVarExp and VarExp.
Sorry, this PR is not perfect to handle the mixing of templates and functions overloading. I'm planning to merge FuncAliasDeclation into OverDeclaration to handle both functions and function templates in same way. This is the first step to do it. |
|
Auto-merge toggled on |
Issue 10658 - Cannot merge template overload set by using alias declaration
ghost
merged commit
|
Thanks!! |
|
This pull request introduced a regression: |
http://d.puremagic.com/issues/show_bug.cgi?id=10658
This relies on the refactoring PR #2401.
Add new
OverDeclarationfor template overload set merging.