Issue 10992 - Missing unittests when using getUnittests trait

[ghost]

http://d.puremagic.com/issues/show_bug.cgi?id=10992

[jacob-carlborg]

Only isUnitTestDeclaration() is not enough. Sometimes it will return null where symbol->unittest won't. If I recall correctly that happens when an UDA is attached to a unit test. I'm pretty sure this is covered in the DMD unit tests.

[ghost]

Will fix up soon.

[ghost]

What was failing before is that I forgot to rename unittest to ddocUnittest at the call sites. It seems the tests are going green now, although I've added this call: Dsymbols *decl = attrDecl->include(NULL, NULL); This call is made almost everywhere attributes are used, so I've added it here as well.

@jacob-carlborg: The tester seems to be going towards green, is there a specific test where using symbol->isUnitTestDeclaration(); didn't work for you?

[jacob-carlborg]

The tester seems to be going towards green, is there a specific test where using symbol->isUnitTestDeclaration(); didn't work for you?

Those with UDA's if I recall correctly.

[ghost]

Well it's green now. :)

[9rnsr]

Adding one more test for this change would be better. Eg.

version(none)
{}
else
{
    unittest { }
    unittest { }
    unittest { }
}

void main()
{
    static assert(__traits(getUnitTests, mixin(__MODULE__)).length == 3);
}

[9rnsr]

@AndrejMitrovic Could you please collect the field renaming (unittest -> ddocUnittest) into the first commit? Separating commits based on those logical purposes would be much better.

[9rnsr]

Other than nitpicks, LGTM.

[ghost]

Separated out logical commits and added another test. But please wait for green.

[ghost]

P.S. for anyone else new to editing specific commits, I've found this SO answer useful: http://stackoverflow.com/a/1186549/279684

Apparently the ^ part at the end is significant too.

[9rnsr]

Thanks for the quick response.