Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTFE optimsation: Remember when constfolding has been done #2570

Closed
wants to merge 1 commit into from

Conversation

donc
Copy link
Collaborator

@donc donc commented Sep 18, 2013

When an array literal or struct literal originated in CTFE, interpreting it again will have no effect.

Potentially this optimsation could have a large impact on compilation time, or may make almost no difference. Let's see,

When an array literal or struct literal originated in CTFE, interpreting
it again will have no effect. This gives a small speedup.
@9rnsr
Copy link
Contributor

9rnsr commented Apr 8, 2014

Please rebase.

@ibuclaw
Copy link
Member

ibuclaw commented Jun 28, 2014

FYI, I can't see any improvement in any of the pathological cases I'm testing this on:

Such as: bug 6498.

  • No notable reduction in memory consumption
  • Compilation is at least a 1 second slower.

@ibuclaw
Copy link
Member

ibuclaw commented Jun 28, 2014

However I'm not discarding the fact that this information is useful. :)

@andralex
Copy link
Member

please rebase

@ibuclaw ibuclaw self-assigned this Oct 11, 2015
@ibuclaw
Copy link
Member

ibuclaw commented Dec 23, 2017

On closer inspection, this was implemented by #4627.

@ibuclaw ibuclaw closed this Dec 23, 2017
@ibuclaw ibuclaw removed their assignment Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants