Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG2.064] Issue 11863 - std.conv.to!string(int/uint, radix) returns incorrect string #3069

Merged
merged 1 commit into from Jan 7, 2014

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Jan 7, 2014

https://d.puremagic.com/issues/show_bug.cgi?id=11863

It looks like that the root issue was incomplete fix of bug 8016 (generate wrong code for nested functions, and corrupt its frame pointer in runtime).
But the bug had been hidden by redundant instantiation of templates (currently it could be done by -allinst switch).

donc pushed a commit that referenced this pull request Jan 7, 2014
[REG2.064] Issue 11863 - std.conv.to!string(int/uint, radix) returns incorrect string
@donc donc merged commit 6090f45 into dlang:master Jan 7, 2014
@donc
Copy link
Collaborator

donc commented Jan 7, 2014

Great work! That was a nasty one.

@MartinNowak
Copy link
Member

Thanks, should we merge this into 2.065?

donc pushed a commit that referenced this pull request Jan 7, 2014
[REG2.064] Issue 11863 - std.conv.to!string(int/uint, radix) returns incorrect string
@9rnsr 9rnsr deleted the fix11863 branch January 7, 2014 10:33
@9rnsr
Copy link
Contributor Author

9rnsr commented Jan 7, 2014

OK, I pushed the merge commit to 2.065 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants