Issue 11969 - ICE(statement.c) When mixing in a string literal containing errors #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntaining errors More error propagation on array elements and AssertExp
| @@ -4480,8 +4491,10 @@ Expression *AssocArrayLiteralExp::semantic(Scope *sc) | |||
| return this; | |||
|
|
|||
| // Run semantic() on each element | |||
| arrayExpressionSemantic(keys, sc); | |||
| arrayExpressionSemantic(values, sc); | |||
| bool err_keys = arrayExpressionSemantic(keys, sc); | |||
There was a problem hiding this comment.
Could do || here as well instead of introducing vars...
There was a problem hiding this comment.
It's not good. If both keys and values have errors, using || would hide the errors in values.
There was a problem hiding this comment.
Good point! I'm sure there are lots of places where we hide independent errors, unfortunately I don't know a way to automatically test for that.
|
Auto-merge toggled on |
yebblies
added a commit
that referenced
this pull request
Jan 22, 2014
Issue 11969 - ICE(statement.c) When mixing in a string literal containing errors
9rnsr
pushed a commit
to 9rnsr/dmd
that referenced
this pull request
Feb 7, 2014
Issue 11969 - ICE(statement.c) When mixing in a string literal containing errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://d.puremagic.com/issues/show_bug.cgi?id=11969
More error propagation on array elements and AssertExp