Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 12077 - Instantiated type does not match to the specialized alias parameter #3210

Merged
merged 4 commits into from Feb 24, 2014

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Feb 5, 2014

@9rnsr
Copy link
Contributor Author

9rnsr commented Feb 5, 2014

This PR depends on #3156 to prevent ICE issue.

@ghost
Copy link

ghost commented Feb 8, 2014

This PR depends on #3156 to prevent ICE issue.

Another feature I'm missing from github, being able to mark pulls as depending on each other.

…a tuple parameter

1. Adjust matching level for issue cases.

 a. `TemplateTupleParameter::matchArg` should always return `MATCHconvert` in order to have the lower priority than other non-tuple templates.
 b. `TemplateTypeParameter::matchArg` and `TemplateAliasParameter::matchArg` should return same match level (== MATCHconvert) for aggregate types.
 c. In leastAsSpecialized comparison, aggregate types should prefer template type parameter. For that, `TemplateAliasParameter::matchArg` should match to `tdummy`.

2. Add "dependent template parameter" concept

 Their `matchArg` should return binary result - match or nomatch, in order to follow the match level of the corresponding precedent parameter.
WalterBright added a commit that referenced this pull request Feb 24, 2014
Issue 12077 - Instantiated type does not match to the specialized alias parameter
@WalterBright WalterBright merged commit 46832fb into dlang:master Feb 24, 2014
@9rnsr 9rnsr deleted the fix12077 branch February 24, 2014 06:17
@CyberShadow
Copy link
Member

This pull request possibly introduced a regression:
https://d.puremagic.com/issues/show_bug.cgi?id=12261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants