Issue 846 - Error 42: Symbol Undefined "<mangle_of_class_template>__arrayZ" #3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-merge toggled on |
| @@ -561,27 +561,14 @@ void TemplateDeclaration::semantic(Scope *sc) | |||
| Type::rtinfo = this; | |||
| } | |||
|
|
|||
| if (sc->module) | |||
| if (Module *m = sc->module) // should use getModule() instead? | |||
| { | |||
| // Generate this function as it may be used | |||
| // when template is instantiated in other modules | |||
| // even if bounds checking is disabled in this module | |||
There was a problem hiding this comment.
Maybe update comment to
Generate these functions as they may be used
when template is instantiated in other modules.
Even if assertions or bounds checking are
disabled in this module.
…>__arrayZ" Stop using ModuleInfo for assertion and array bounds check. Instead pass filename to `_d_assert`, `_d_unittest`, and `_d_arraybounds`.
MartinNowak
added a commit
that referenced
this pull request
May 17, 2014
Issue 846 - Error 42: Symbol Undefined "<mangle_of_class_template>__arrayZ"
|
Thanks! |
This was referenced Aug 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=846
It's separated from #2561. Even if an instantiated template is defined in non-root module, generate
_array,__assert, and__unittest_failfor the module in COMDAT section.