Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 12798 - constant folding should optimize subsequent concatenations #3581

Merged
merged 1 commit into from
May 25, 2014

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented May 25, 2014

@9rnsr
Copy link
Contributor Author

9rnsr commented May 25, 2014

This is necessary for @nogc improvement in #3582.

WalterBright added a commit that referenced this pull request May 25, 2014
Issue 12798 - constant folding should optimize subsequent concatenations
@WalterBright WalterBright merged commit 99ccc90 into dlang:master May 25, 2014
@9rnsr
Copy link
Contributor Author

9rnsr commented May 25, 2014

Thanks!

@9rnsr 9rnsr deleted the fix12798 branch May 25, 2014 21:39
@ibuclaw
Copy link
Member

ibuclaw commented Oct 17, 2014

This patch has been the cause of an ICE deep deep in the backend of GCC. I can't see an immediate reason why though. But I guess that this shortcuts something in the codegen.

@ibuclaw
Copy link
Member

ibuclaw commented Oct 17, 2014

Scratch that, it may appear that this reveals an ICE deep deep in the backend of GCC.

@ibuclaw
Copy link
Member

ibuclaw commented Oct 17, 2014

But I still can't reproduce when I roll back to 2.065... sigh something else between this and initial development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants