Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use enums #3750

Merged
merged 1 commit into from Jul 13, 2014
Merged

use enums #3750

merged 1 commit into from Jul 13, 2014

Conversation

Trass3r
Copy link
Contributor

@Trass3r Trass3r commented Jul 12, 2014

Distilled some parts out of #650.
Enables nice VS .natvis debugger visualization (btw would people be interested in a shared natvis?)

I also turned STC into an enum, but the values are >32 bits so not sure what happens then in C++03.

{
if (mod1 == mod2)
return mod1;

//printf("MODmerge(1 = %x, 2 = %x)\n", mod1, mod2);
unsigned char result = 0;
MOD result = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong tab.

@Trass3r
Copy link
Contributor Author

Trass3r commented Jul 13, 2014

Done.

@9rnsr
Copy link
Contributor

9rnsr commented Jul 13, 2014

Thanks. LGTM.

@9rnsr
Copy link
Contributor

9rnsr commented Jul 13, 2014

Auto-merge toggled on

9rnsr added a commit that referenced this pull request Jul 13, 2014
@9rnsr 9rnsr merged commit 2ca83ba into dlang:master Jul 13, 2014
9rnsr added a commit to 9rnsr/dmd that referenced this pull request Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants