[DDMD] Issue 13182 - extern(C++) classes cause crash when allocated on the stack with scope #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2222,6 +2222,10 @@ Expression *VarDeclaration::callScopeDtor(Scope *sc) | |||
| */ | |||
| //if (cd->isInterfaceDeclaration()) | |||
| //error("interface %s cannot be scope", cd->toChars()); | |||
| if (cd->cpp) | |||
| { | |||
| break; | |||
There was a problem hiding this comment.
Add comment explaining why.
…he stack with scope Destructors are not currently allowed on extern(C++) classes, so it should not call delete at all.
|
Comment added. |
|
Now green. |
WalterBright
added a commit
that referenced
this pull request
Jul 23, 2014
[DDMD] Issue 13182 - extern(C++) classes cause crash when allocated on the stack with scope
|
Thanks! |
9rnsr
pushed a commit
to 9rnsr/dmd
that referenced
this pull request
Jul 23, 2014
[DDMD] Issue 13182 - extern(C++) classes cause crash when allocated on the stack with scope
ibuclaw
pushed a commit
to ibuclaw/dmd
that referenced
this pull request
Jul 10, 2022
add nothrow to windows files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destructors are not currently allowed on extern(C++) classes, so it should not call delete at all.
https://issues.dlang.org/show_bug.cgi?id=13182