[DDMD] Use an alloc function for Token freelist instead of operator new. #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Lexer::freelist = t->next; | ||
| t->next = NULL; |
There was a problem hiding this comment.
You should probably either assign from a default constructed object or use placement new because it's not obvious that this should be kept in sync with the default constructor.
There was a problem hiding this comment.
alloc doesn't have to initialize the memory properly. I just wanted to drop it out of the freelist completely.
|
Auto-merge toggled on |
WalterBright
added a commit
that referenced
this pull request
Jul 25, 2014
[DDMD] Use an alloc function for Token freelist instead of operator new.
9rnsr
pushed a commit
to 9rnsr/dmd
that referenced
this pull request
Jul 28, 2014
[DDMD] Use an alloc function for Token freelist instead of operator new.
ibuclaw
pushed a commit
to ibuclaw/dmd
that referenced
this pull request
Jul 10, 2022
add clarifying examples of SIMD usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows both C++ and D to both use the custom freelist.