[REG2.066] Issue 13294 - [IFTI] IFTI fails or works incorrectly for function with const and mutable ref parameters of most types
#3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To @WalterBright @andralex @AndrewEdwards and all other comitters: Issue 13294 is a terrible regression in 2.066 release so it breaks many existing template function code. I think we should release minor update 2.066.1 in order to fix 13294. |
| @@ -1074,6 +1074,31 @@ MATCH TemplateDeclaration::leastAsSpecialized(Scope *sc, TemplateDeclaration *td | |||
| return MATCHnomatch; | |||
| } | |||
|
|
|||
| struct TypeDeduced : Type | |||
There was a problem hiding this comment.
This needs to be a class, not a struct.
9rnsr
force-pushed
the
fix13294
branch
2 times, most recently
from
d05f866
to
ee7c262
Compare
… with const and mutable `ref` parameters of most types This is more better implementation of enhancement 12290. The first implementation dlang#3353 was incomplete, so sadly it had introduced many IFTI regressions - 12403, 13026, 13180, 13223, and 13294. Eventually I noticed that using typeMerge was wrong. It was the biggest root the regressions. And, the enhancement 13127 was pointless change. Now it is mostly reverted.
|
The number of changes for a patch to merge with 2.066 makes me nervous, but will give it a try. |
|
Auto-merge toggled on |
WalterBright
added a commit
that referenced
this pull request
Aug 25, 2014
[REG2.066] Issue 13294 - [IFTI] IFTI fails or works incorrectly for function with const and mutable `ref` parameters of most types
9rnsr
pushed a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 26, 2014
[REG2.066] Issue 13294 - [IFTI] IFTI fails or works incorrectly for function with const and mutable `ref` parameters of most types
|
Adding a new type of |
|
This pull request introduced a regression: |
|
This PR introduced a regression: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=13294
This is more better implementation of enhancement 12290.
The first implementation #3353 was incomplete, so sadly it had introduced many IFTI regressions - 12403, 13026, 13180, 13223, and 13294.
Eventually I noticed that using typeMerge was wrong. It was the biggest root the regressions.
And, the enhancement 13127 was pointless change. Now it is mostly reverted.