[REG2.067a] Issue 13379 - Latest dmd fails with recursive template expansion in std.regex #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while (tix && tix != inst) | ||
| tix = tix->tinst; | ||
| if (tix != inst) // Bugzilla 13379: Prevent circular chain | ||
| inst->tinst = tinst; |
There was a problem hiding this comment.
When an instance X [1] instantiates Y, then Y instantiates X [2], inst == X [1] and this == X [2].
The the old code had been breaking the assumption that inst does not appear in the chain of inst->tinst.
|
The regression is introduced in #3874, and the fix is now on 2.066 branch. So this is a blocker for the 2.066 point release. Please review. |
|
Some of my projects are currently non-compilable on git head because of this issue. Please merge soon. :) |
|
Please review and merge. |
WalterBright
added a commit
that referenced
this pull request
Aug 31, 2014
[REG2.067a] Issue 13379 - Latest dmd fails with recursive template expansion in std.regex
9rnsr
pushed a commit
to 9rnsr/dmd
that referenced
this pull request
Aug 31, 2014
[REG2.067a] Issue 13379 - Latest dmd fails with recursive template expansion in std.regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=13379