Issue 13860 - template required forward reference for typeof(member) #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9rnsr
force-pushed
the
fix13860
branch
3 times, most recently
from
2cae5e0
to
3a5c42c
Compare
In a struct member function S.foo, 'this' is declared as a ref variable by `declareThis()` in `FuncDeclaration::semantic3()`. But in `VarDeclaration::semantic`, `type->hasPointer()` will needlessly try to resolve struct fwdref. All parameter variables won't be declared with void initializer, so the reordering fixes the issue.
|
Auto-merge toggled on |
yebblies
added a commit
that referenced
this pull request
Jan 20, 2015
Issue 13860 - template required forward reference for typeof(member)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=13860
In a struct member function S.foo, 'this' is declared as a ref variable by
declareThis()inFuncDeclaration::semantic3().But in
VarDeclaration::semantic,type->hasPointer()will needlessly try to resolve struct fwdref.All parameter variables won't be declared with void initializer, so the reordering fixes the issue.