Fix issue 14375 - static assert leads to __traits(allMembers) retuning an extra empty entry

[Geod24]

The problem was that StaticAssert had an empty identifier instead of a null one, which is expected by allMember.
By the way is there a reason why Id::empty is empty string instead of NULL ?

[9rnsr]

Id::empty is used to avoid NULL check for the ident member access.

ident == NULL is used for the anonymous members which not yet semantic analysis finished. For example, an anonymous class creation new class (arguments) { ... } internally defines a ClassDeclaration with NULL ident, then it will be filled by the unique name in ClassDeclaration::semantic().

[9rnsr]

Using strlen for the Identifier object is costly operation. Instead of that, you can use more lightweight comparison sm->ident != Id::empty.

[Geod24]

Thanks for the explanation!
I changed the commit accordingly to just exclude Id::empty.

Btw: Should I submit this against stable as well / instead ?

[9rnsr]

LGTM.

Btw: Should I submit this against stable as well / instead ?

Even so, we can cherry-pick the commit later into stable branch.

[9rnsr]

Auto-merge toggled on