Issue 5481 - Support deprecated("message")

[yebblies]

Add an optional message to deprecated.

[andralex]

This is a highly useful feature. I think we should merge it in and document it properly.

[ghost]

If the code to handle @disable is similar to @deprecated we could consider implementing messages for the former too in another pull request. http://d.puremagic.com/issues/show_bug.cgi?id=8728

[nazriel]

LGTM 👍
Indeed it is very useful.

@yebblies what do you think about adding unittest for failure (without -d) and asserting about correct deprecated message being displayed?

@9rnsr @dawgfoto what you think?

[yebblies]

@nazriel Does the autotester support that? I don't remember any other tests that check the output from dmd.

[dnadlinger]

@yebblies: Kenji recently added support for that, see e.g. 21f32ed.

[nazriel]

@yebblies won't https://github.com/D-Programming-Language/dmd/blob/master/test/d_do_test.d#L178 work?
I think I saw it somewhere in action for Error message enhancement PR

Edit: Ups, @klickverbot was faster. And yea, that's exactly the PR I was looking for.

[yebblies]

Awesome, done. The duplicated error messages are caused by a different bug.

[nazriel]

Umm, auto tester bug or I am blind? Because I see no difference between expected and actual output (for example here http://d.puremagic.com/test-results/pull.ghtml?runid=316239)

DOWN: so the latter. NOT good *grins

[yebblies]

Path separators

[WalterBright]

LGTM

[braddr]

This pull needs a quick rebase due to a conflict introduced by pulling in the other deprecation refactoring pull.

[yebblies]

Done.

[nazriel]

@9rnsr @dawgfoto any final words? Can we merge it please?

[9rnsr]

Merged!

[yebblies]

Thanks all!

[andralex]

Great work everyone. This solves a known, long-standing issue to which we had no good solution. A solution has been proposed, implemented, and reviewed by the community and got approved by the BDFL. Congratulations to all involved!