Issue 14992 - static array local variables always require .init #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, would you say that this makes dlang/druntime#1372 unnecessary or are there cases in which it will still be needed? |
|
Currently, typeinfo object for struct should be generated on demand. So, such the interface modules for C library bindings do not have to be compiled and included in druntime. |
| * memset(&sarray, 0, struct.sizeof) | ||
| */ | ||
| elem *ey = NULL; | ||
| unsigned sz = ae->e1->type->size(); |
There was a problem hiding this comment.
Should be targ_size_t, not unsigned.
|
Add one more special case for static array of struct initialization with zero, similar to the special case for struct initialization.
|
Nice optimization. :-) |
|
Auto-merge toggled on |
ibuclaw
added a commit
that referenced
this pull request
Feb 7, 2016
Issue 14992 - static array local variables always require .init
|
Please do refactorings as SEPARATE PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14992
Add one more special case for static array of struct initialization with zero, similar to the special case for struct initialization.