fix OSX 32 build #5107
Merged
fix OSX 32 build #5107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you the only person using OSX32? |
| @@ -206,7 +206,7 @@ type *type_dyn_array(type *tnext); | |||
| extern "C" type *type_static_array(targ_size_t dim, type *tnext); | |||
| type *type_assoc_array(type *tkey, type *tvalue); | |||
| type *type_delegate(type *tnext); | |||
| type *type_function(tym_t tyf, type **ptypes, size_t nparams, bool variadic, type *tret); | |||
| extern "C" { type *type_function(tym_t tyf, type **ptypes, size_t nparams, bool variadic, type *tret); } | |||
|
Quite possibly. But as I pointed out last time this came up, these changes make it work for any future port that may have a peculiar typedef for size_t. |
|
That would be a more important concern if we were planning to keep the backend in C++ long term. At the moment we don't have any officially supported backends that need this and we are unlikely to ever add any. Anyway, I'll pull this with the braces change. |
WalterBright
force-pushed
the
fixosx32
branch
from
6789659
to
31e72fa
Compare
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it broke again.