Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up #ifdefs that split up parts of statements. #5278

Merged
merged 2 commits into from Nov 27, 2015
Merged

Cleaning up #ifdefs that split up parts of statements. #5278

merged 2 commits into from Nov 27, 2015

Conversation

ghost
Copy link

@ghost ghost commented Nov 20, 2015

A suggestion to compile entire statements and expressions, as suggested by code style guidelines from the Linux Kernel and practitioners.

It might improve code understanding, maintainability and error-proneness.

I noticed that the project uses this types of directives a lot by running my tool. I'm willing to contribute by removing those issues if it is important to the project.

@yebblies
Copy link
Member

This would be fine except for the unnecessary extra parentheses.

WalterBright added a commit that referenced this pull request Nov 27, 2015
Cleaning up #ifdefs that split up parts of statements.
@WalterBright WalterBright merged commit fc42ae8 into dlang:master Nov 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants