Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing import of stdio when logging #5341

Merged
merged 1 commit into from Jan 24, 2016
Merged

Missing import of stdio when logging #5341

merged 1 commit into from Jan 24, 2016

Conversation

joakim-brannstrom
Copy link
Contributor

No description provided.

@AndrejMitrovic
Copy link
Contributor

LGTM but commit messages should be in the imperative, e.g. Add missing stdio import

@yebblies
Copy link
Member

Bracing style, and might as well just make it an unconditional import.

@joakim-brannstrom
Copy link
Contributor Author

Fixed and rebased :)

@AndrejMitrovic
Copy link
Contributor

Auto-merge toggled on

AndrejMitrovic added a commit that referenced this pull request Jan 24, 2016
@AndrejMitrovic
Merge pull request #5341 from joakim-brannstrom/missing_stdio_import
3c1e4d5 
Missing import of stdio when logging
@AndrejMitrovic AndrejMitrovic merged commit 3c1e4d5 into dlang:master Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@joakim-brannstrom @AndrejMitrovic @yebblies