Fix 15668 : __LINE__ evaluated at declaration context #5435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompile time when using -inline CTFE interpretr can recognize a form `CommaExp(DeclaraationExp(v), VarExp(v))` as a CTFEable variable declaration when `v._init` is `null`. In other cases, for examle a sole `DeclarationExp` should have v._init for CTFE-ability. Supply `VoidInitializer` to allow inlining the temporary for NRVO.
[REG 2.067] Issue 15490 - Error variable __nrvoretval cannot be modified at compile time when using -inline
|
Looks OK to me. @9rnsr? |
|
The commit title should include "Fix" though. |
|
Updated commit title. |
|
Looks good. Thanks! |
|
Auto-merge toggled on |
|
(PR #4261 was opened for 3 months. Maybe I got the mistake during its repeated rebasing.) |
|
Auto-merge toggled off |
|
@Dicebot Sorry, usually a regression fix should be based on |
Relevant argument deduction code was using declaration `loc` instead of instantiation `instLoc`
|
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant argument deduction code was using declaration
locinstead of instantiation
instLoc. Not sure if this is correct fix but at least it has helped with my test case :)Fixes https://issues.dlang.org/show_bug.cgi?id=15668