Issue 15857 - incorrect checkimports mismatch for overload sets #5681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cache the generated `OverloadSet` object into scope, and prevent repetition of identical objects.
MartinNowak
added a commit
to MartinNowak/dmd
that referenced
this pull request
Sep 16, 2016
- properly fix Issue 15857 by comparing overload sets for equality (see 082e119 or dlang#5681 for the previous fix) - caching them in the local symbol table doesn't fully fix the issue b/c the table is not checked w/ SearchImportsOnly (see added test case) - also with -transition=checkimports adding an overload set to the local symbol table will return that overload set for locals only searches, even though it might contain imported overloads (see readded dip22e deprecation) - might still make sense to correctly cache overload sets at some point, but they shouldn't be that common
UplinkCoder
pushed a commit
to UplinkCoder/dmd
that referenced
this pull request
Nov 3, 2016
- properly fix Issue 15857 by comparing overload sets for equality (see 082e119 or dlang#5681 for the previous fix) - caching them in the local symbol table doesn't fully fix the issue b/c the table is not checked w/ SearchImportsOnly (see added test case) - also with -transition=checkimports adding an overload set to the local symbol table will return that overload set for locals only searches, even though it might contain imported overloads (see readded dip22e deprecation) - might still make sense to correctly cache overload sets at some point, but they shouldn't be that common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the generated
OverloadSetobject into scope, and prevent repetition of identical objects.