Move complex/imaginary types from transition to deprecation

[ibuclaw]

Does not attempt to move checking anywhere else.

[ibuclaw]

Yay! Deprecation messages everywhere!

@yebblies @CyberShadow - ideas welcome. Just speaking to @schveiguy and preferably we'd have the deprecation only emitted once per module. This should be trivial to do.

[CyberShadow]

../phobos/std/internal/test/uda.d(8): Error: enum std.internal.test.uda.Attr is forward referenced looking for base type

How did this get broken?

[schveiguy]

Just a note: I saw @ibuclaw's output before and after he made it so there was one message printed per module. So so much better afterwards.

I'm of absolutely no use to help review or help fix any failures here. But I just wanted to chime in with my approval of the idea to make it one message per module.

I don't know if we can fix Phobos to avoid printing so much warnings otherwise. It may be possible, but it means a goofy refactoring of the code.

[ibuclaw]

@CyberShadow apparently the place where I put the check for complex types is too early.

[ibuclaw]

Going to move it from semantic -> semantic3

[ibuclaw]

Oh, there is no semantic3 for TypeExp. :-\

[wilzbach]

Yay! Deprecation messages everywhere!

As auto-tester fails currently I just did a quick grep over Phobos, and it doesn't seem that bad ;-)

ifloat: 18
idouble: 22
ireal: 23
cfloat: 19
cdouble: 28
creal: 43

Btw: How about adding a EOL and final deprecation date to the warning and code?
e.g They will be removed in March 2017. @@@DEPRECATED_2017-03@@@

[wilzbach]

A new issue "cdouble is broken" just bumped in, it might be worth to get this in sooner than later? ;-)

[ibuclaw]

Yes. What needs to happen is to move these deprecations closer to the end of the semantic analysis pass. These current checks can happen before all symbols are resolved, hence the failures.

[ibuclaw]

Closing as I created a new PR on this.