Bug7097

[MartinNowak]

• resolve opDollar for all array operator overloads (op[Index,Slice][, Unary, Assign, OpAssign])
• throw out the deprecated resolving of 'length' to opDollary
  not doing so could break code that uses a length variable/property within
  one of the added expressions

[yebblies]

It is probably worth using ad->search instead here, this allows opDollar to match any declaration instead of just functions.

See #203 for an example.

[MartinNowak]

Yeah, we should do that.

[9rnsr]

I'm surprised that bug 7097 is not yet fixed. I've found it in the reviewing of this pull.

[MartinNowak]

I could probably get to this within this week. Are you working on that one too?

[9rnsr]

Yesterday, I've started to fix, but I found this pull after that. Then I stopped my work.
This pull is enough better.

[MartinNowak]

Sorry, I should have created a backlink in bugzilla.

[dnadlinger]

Can we get this in before the next release?

[9rnsr]

I'd like to merge this in 2.060. @dawgfoto , can you rebase this?

[andralex]

http://d.puremagic.com/issues/show_bug.cgi?id=7097

[andralex]

It was unclear to me from a cursory look - does opDollar work with infinite ranges? The following should work:

struct A {
    enum empty = false;
    struct Dullah {}
    Dullah opDollar() { return Dullah.init; }
    A opSlice(size_t from, Dullah) { ... }
}

In other words, it should be possible to slice an infinite range with r[1 .. $].

[9rnsr]

In other words, it should be possible to slice an infinite range with r[1 .. $].

It would work. All of operator overloading mechanisms would work just like syntactic rewriting.
So, r[1 .. $] should be rewritten to r.opSlice(1, r.opDollar()), and such call expression would work.

[andralex]

Then I approve the design of this diff. Committers, please review implementation and merge. Thanks!

[9rnsr]

@dawgfoto, you had already rebased the commits two months ago, but I didn't noticed it. Sorry.
And now, it is necessary again.

So, please re-rebase commits, and write comment in here. Github would notify me the comment by e-mail, and I'll be able to merge this immediately.

[donc]

This has not worked up until now, because my original opDollar implementation was very conservative (I made the patch before the feature was actually accepted). It only worked with indexing, and I tried to make sure it as unintrusive as possible. This LGTM.

[yebblies]

@dawgfoto Bump for a rebase.

[MartinNowak]

OK

[9rnsr]

Thanks for your work, @dawgfoto!