[REG 2.067] Fix wrong struct and align size for anonymous aggregates #5776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuclaw
changed the title
|
Failing test has nothing to do with this. |
|
Testing |
|
No, and I don't think there is any good test for this. Anonymous declarations can't really be touched by user code. It's also a shame that DMD flattens the fields list for aggregates also. GDC is the only user of these |
|
OK. |
|
Auto-merge toggled on |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://bugzilla.gdcproject.org/show_bug.cgi?id=215
Because of Bugzilla 13613, the current logic means that the anonstructsize and anonalignsize are reset to
0eagerly. Instead they should only be updated if any members were added.