Add PS4 version identifier #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks all green in all checks! |
|
Discussions going on in this post: https://forum.dlang.org/thread/ztsojwrjqvqqazlblbxw@forum.dlang.org |
|
LLVM calls it the PS4 toolchain and defines it as |
|
@yebblies: Okay to go with PS4? |
|
I'd rather PlayStation4 |
|
I vote |
Add PlayStation4 version identifier
|
I have now changed it to reserve PlayStation4 as well as PlayStation instead of PS4. The reasoning behind reserving PlayStation as well is incase there are code that can be reused between PS4 and a future theoretical PS5. If any additions to reserved version keywords also gets reserved like Johan said my reasoning behind reserving PlayStation4 as well is for claritys sake. |
JohanEngelen
added a commit
to JohanEngelen/dmd
that referenced
this pull request
Jun 13, 2016
JohanEngelen
added a commit
to JohanEngelen/dmd
that referenced
this pull request
Jun 13, 2016
JohanEngelen
added a commit
to JohanEngelen/dmd
that referenced
this pull request
Jun 13, 2016
JohanEngelen
added a commit
to JohanEngelen/dmd
that referenced
this pull request
Jun 13, 2016
WalterBright
added a commit
that referenced
this pull request
Jun 14, 2016
Add version(PlayStation) test for PR #5850
redstar
added a commit
to redstar/dlang.org
that referenced
this pull request
Jun 28, 2016
They were introduced with dlang/dmd#5850.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started a fork of LDC intended to attempt to add compatibility for the PS4 similar to what exists in the main branch of Clang.
This would require a version identifier, the alternatives I propose is either PS4 or ORBIS.
Orbis OS is the official name of the operating system on the PS4 and Sony refers to the whole platform as ORBIS.
I personally believe that PS4 is a better choice seeing as it's more descriptive and a bit less obscure than ORBIS.