add size() checks to declaration.d #6065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
force-pushed
the
size-declaration.d
branch
2 times, most recently
from
635c46e
to
3db6b13
Compare
Current coverage is 81.95% (diff: 100%)@@ master #6065 diff @@
==========================================
Files 96 96
Lines 55797 55776 -21
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 48774 45709 -3065
- Misses 7023 10067 +3044
Partials 0 0
|
Huh? |
WalterBright
force-pushed
the
size-declaration.d
branch
from
3db6b13
to
f1ec6b8
Compare
| const vsz = v.type.size(); | ||
| const tsz = type.size(); | ||
| assert(vsz != SIZE_INVALID && tsz != SIZE_INVALID); | ||
| return ( offset < v.offset + vsz && |
There was a problem hiding this comment.
Also: return (expr); is an unrecommended (we should use a style rule to automatically reject it), use return expr;
There was a problem hiding this comment.
The spaces are to line things up with the next line. I removed the parens.
WalterBright
force-pushed
the
size-declaration.d
branch
from
f1ec6b8
to
a4a2eee
Compare
| @@ -976,7 +976,7 @@ public: | |||
| { | |||
| // Bugzilla 13776: Don't use ti->toAlias() to avoid forward reference error | |||
| // while printing messages. | |||
| TemplateInstance ti = t.sym.parent.isTemplateInstance(); | |||
| TemplateInstance ti = t.sym.parent ? t.sym.parent.isTemplateInstance() : null; | |||
There was a problem hiding this comment.
It is. It crashes otherwise.
There was a problem hiding this comment.
It crashes otherwise.
It does indeed
|
Auto-merge toggled on |
|
This caused a regression. |
wilzbach
reviewed
May 29, 2017
| return null; | ||
|
|
||
| const sz = type.size(); | ||
| assert(sz != SIZE_INVALID); |
There was a problem hiding this comment.
Apparently the sz can have an invalid size: https://issues.dlang.org/show_bug.cgi?id=17451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect against size() failures and divide-by-zero. Not sure if any of these could happen, but added asserts to be sure.