Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 15703 - @safe code should not allow certain types of array … #6086

Merged
merged 1 commit into from Aug 26, 2016

Conversation

WalterBright
Copy link
Member

…casts

@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
15703 @safe code should not allow certain types of array casts

@dlang-bot
Copy link
Contributor

@WalterBright, thanks for your PR! By analyzing the annotation information on this pull request, we identified @yebblies, @9rnsr and @MartinNowak to be potential reviewers. @yebblies: The PR was automatically assigned to you, please reassign it if you were identified mistakenly.

(The DLang Bot is under development. If you experience any issues, please open an issue at its repo.)

@codecov-io
Copy link

codecov-io commented Aug 26, 2016

Current coverage is 87.42% (diff: 100%)

Merging #6086 into master will increase coverage by <.01%

@@             master      #6086   diff @@
==========================================
  Files            97         97          
  Lines         56192      56194     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          49126      49128     +2   
  Misses         7066       7066          
  Partials          0          0          

Powered by Codecov. Last update 627e96b...811ddf9

@WalterBright WalterBright force-pushed the fix15703 branch 2 times, most recently from 811ddf9 to a2fdf03 Compare August 26, 2016 06:41
@@ -0,0 +1,32 @@
/*
REQUIRED_ARGS: -m32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is -m32 necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I wanted the integral type to match in size the pointer type. But size_t comes out as uint or ulong depending on -m32 or -m64, and then the error messages don't match.

@andralex andralex merged commit e9594ec into dlang:master Aug 26, 2016
@WalterBright WalterBright deleted the fix15703 branch August 26, 2016 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants