fix Issue 16095 - a delegate can mutate immutable data and break shar… #6091
Conversation
…ed / non-shared enforcements
|
|
@WalterBright, thanks for your PR! By analyzing the annotation information on this pull request, we identified @yebblies, @9rnsr and @MartinNowak to be potential reviewers. @yebblies: The PR was automatically assigned to you, please reassign it if you were identified mistakenly. |
| MODMatchToBuffer(&thisBuf, e1.type.mod, tf.mod); | ||
| MODMatchToBuffer(&funcBuf, tf.mod, e1.type.mod); | ||
| error("%smethod %s is not callable using a %s%s", | ||
| funcBuf.peekString(), f.toPrettyChars(), thisBuf.peekString(), e1.toChars()); |
There was a problem hiding this comment.
I think this should be e1.type.toChars(), the diagnostic is currently saying you can't call a method with a non-shared a, but a is just a variable, it should specify the type instead.
There was a problem hiding this comment.
But non-shared is what I need to know about the type, and I need to know it is a that's the problem.
There was a problem hiding this comment.
Hm you may be right. I was under the wrong impression that we used to print the type name, but existing diagnostics are:
class C
{
void ping() { }
}
void main()
{
auto c = new const C;
c.ping();
}Error: mutable method test.C.ping is not callable using a const object
I suppose your approach works fine. :)
|
Auto-merge toggled on |
…ed / non-shared enforcements