fix Issue 16607 - forward reference error for nested struct #6214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This reverts removing the AggregateDeclaration.setScope override (see 75b5b69) and fixes a wrong error triggered by setting _scope on a SIZEOKdone struct during deferred setScope phases (outer struct has forward references).
|
CyberShadow
reviewed
Oct 25, 2016
| @@ -0,0 +1,15 @@ | |||
| struct A(T) | |||
| { | |||
| T t; // causes A to be SIZEOKfwd b/c B (passed as T) isn't yet done | |||
There was a problem hiding this comment.
Thank you! But would it be much to ask to avoid shortening words in commits in the future? They might not be very accessible to everyone depending on their English level.
There was a problem hiding this comment.
Mmh, only unwillingly, I'm fairly used to that style and have a lot of stuff to type each day.
I wouldn't do that in a changelog entry or specs, but I don't see how that increases any hurdle.
If you're already starring at test16607.d, you're deep into mud anyhow.
There was a problem hiding this comment.
Thanks for raising this, getting understood is important, and this is a useful consideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
75b5b69) and fixes a wrong error triggered by setting _scope on a
SIZEOKdone struct during deferred setScope phases (outer struct has
forward references).