eliminate quadratic behavior in updaterd() #6356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This precomputes the vector needed for
updaterd()
, whereas before it was computed on the fly. It did that to minimize memory consumption, but that is much less of factor these days. So we're trading memory consumption for speed.In some pathological cases, i.e. https://issues.dlang.org/show_bug.cgi?id=7157, this change doubles the speed of the optimization pass. The time taken is still quadratic, though.
accumaecpx()
remains quadratic.