Fix issue 16598 - Explicitly discard the exp. value in void CondExp #6434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Please also change the base branch to stable. |
|
As you can see a little change to |
|
@LemonBoy all bug fixes should go to the stable branch. You need to rebase your branch locally against upstream/stable (considering your git remote for dlang/dmd is named upstream) and force push your branch. |
|
Just rebased myself, sorry for the force push to your branch @LemonBoy. |
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a leaf has
voidas type then the whole expression gets thevoidtype, by explicitly discarding the value of the non-void leaf we avoid a nasty ICE during the codegen phase in the attached test case: thegfunction returns anintbut the frontend states that the whole expression isvoidso no registers are allocated for the return value.