fix Issue 17761 - don't leave behind empty section groups #7093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @MartinNowak! Bugzilla references
|
src/ddmd/backend/elfobj.c
Outdated
| Returns: | ||
| String index of new or existing section name. | ||
| */ | ||
| static IDXSEC elf_addsectionname(const char *name, const char *suffix = NULL, bool *padded = NULL) |
WalterBright
requested changes
Aug 23, 2017
- split into elf_addsectionname, elf_addsegment, and elf_getsegment - add out parameter to addsectionname for newly added entries
- check for existing .text.<mangling> section before opening new group section, reuse existing sections in case of colliding mangling
|
Done @WalterBright |
WalterBright
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
group section, reuse existing sections in case of colliding mangling
Until now it wasn't easily possible to lookup an existing section, hence the refactoring was necessary for the fix. At best review commits separately. I've also added more detailed documentation to those functions.