Remove unused FLAGS aliases #7752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
JinShil
approved these changes
Jan 19, 2018
jacob-carlborg
approved these changes
Jan 19, 2018
src/dmd/lexer.d
Outdated
| @@ -1988,9 +1983,10 @@ class Lexer | |||
| if (base == 8 && n >= 8) | |||
| error("octal literals `0%llo%.*s` are no longer supported, use `std.conv.octal!%llo%.*s` instead", n, p - psuffix, psuffix, n, p - psuffix, psuffix); | |||
| TOK result; | |||
| with(FLAGS) | |||
There was a problem hiding this comment.
I'd rather not start using with.
wilzbach
force-pushed
the
remove-unused
branch
from
0cad4df
to
e7ea8c1
Compare
wilzbach
force-pushed
the
remove-unused
branch
from
e7ea8c1
to
046b2a0
Compare
|
(removed `with) |
PetarKirov
dismissed
WalterBright’s stale review
Requested changes were made.
|
Argh Jenkins seems to be losing PRs more and more frequently :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are only used once below. We can even use
withto make it look nicer.