Fix Issue 18460 - Improve error message for missing 'new' for class instantiation #7929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
commented
Feb 20, 2018
| error(loc, "no property `%s` for type `%s`", ident.toChars(), toChars()); | ||
| { | ||
| if (ident == Id.call && ty == Tclass) | ||
| error(loc, "no property `%s` for type `%s`, did you mean `new %s`?", ident.toChars(), toChars(), toPrettyChars()); |
There was a problem hiding this comment.
BTW any reason why toChars is always fully qualified for classes, but not for structs?
There was a problem hiding this comment.
I don't know. I suppose that should also be addressed (in another PR).
JinShil
approved these changes
Feb 21, 2018
jacob-carlborg
approved these changes
Feb 21, 2018
PetarKirov
reviewed
Feb 24, 2018
| /* | ||
| TEST_OUTPUT: | ||
| --- | ||
| fail_compilation/diag18460.d(12): Error: no property `opCall` for type `diag18460.Foo`, did you mean `new Foo`? |
There was a problem hiding this comment.
Error: no `static` property `opCall` for...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One small step on the long road to better diagnostics.