[dmd-cxx]: Fix the auto-tester and copy dmd to $(GENERATED)/$(OS)/$(BUILD)/$(MODEL) #7953

wilzbach · 2018-02-24T23:46:15Z

This should ideally fix the auto-tester build for dmd-cxx as Travis is already passing too.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

wilzbach · 2018-02-25T01:32:52Z

Hmm, Phobos still fails to build.
The error can be reproduced by running make -f posix.mak checkwhitespace locally.
Here with a more verbose error message:

std/uni.d: Error: generated function std.uni.InversionList!(GcPolicy).InversionList.Intervals!(CowArray!(GcPolicy)).Intervals.__xopEquals errors compiling the function
make: *** [posix.mak:520: checkwhitespace] Error 1

@dkgroot you mentioned on Slack that dmd-cxx works for you?

We could also just stub out checkwhitespace at dmd-cxx for now and see whether we get the testsuite running.

edit: -> see dlang/phobos#6220

dkgroot · 2018-02-26T13:38:10Z

@wilzbach
Not sure how i got through last time i check (Maybe i only ran compile).

With the current version (ie: dmd + druntime + phobos using branch 'dmd-cxx'), compilation runs fine (still), using: make -f posix.mak BUILD=debug ENABLE_DEBUG=1 PIC=1 DMD=../dmd/src/dmd. Note: i am not seeing the checkwhitespace you mentioned.

running the unittests for druntime, i get:

make[1]: Entering directory '/data/develop/dmd/dmd-cxx/druntime/test/exceptions'
/data/develop/dmd/dmd-cxx/dmd/src/dmd -m64 -w -I../../src -I../../import -Isrc -defaultlib= -debuglib= -dip1000 -fPIC -L/data/develop/dmd/dmd-cxx/druntime/generated/linux/debug/64/libdruntime.a -g -debug -ofgenerated/linux/debug/64/unknown_gc src/unknown_gc.d
DMD v2.069-devel-daf285aea-dirty DEBUG
Testing unknown_gc
./generated/linux/debug/64/unknown_gc  2>&1 1>/dev/null | grep -qF "'unknowngc'"
Segmentation fault (core dumped)
Testing line_trace

Meaning something goes wrong in catching the thrown exception.

running the unittests for phobos:, i get:

generated/linux/debug/64/unittest/test_runner std.outbuffer
generated/linux/debug/64/unittest/libphobos2-ut.so(_D4core7runtime18runModuleUnitTestsUZ19unittestSegvHandlerUNbiPS4core3sys5posix6signal9siginfo_tPvZv+0x3a)[0x7f8eaf0598ca]
/lib/x86_64-linux-gnu/libc.so.6(+0x37140)[0x7f8ea949f140]
generated/linux/debug/64/unittest/libphobos2-ut.so(_D4core4stdc6stdarg7va_copyFNbJPS4core4stdc6stdarg13__va_list_tagPS4core4stdc6stdarg13__va_list_tagPvZv+0x2d)[0x7f8eaf063575]
generated/linux/debug/64/unittest/libphobos2-ut.so(_D3std9outbuffer9OutBuffer7vprintfMFNbNeAyaPS4core4stdc6stdarg13__va_list_tagZv+0xca)[0x7f8ead4d67ba]
generated/linux/debug/64/unittest/libphobos2-ut.so(_D3std9outbuffer9OutBuffer6printfMFNeAyaYv+0xa0)[0x7f8ead4d6950]
generated/linux/debug/64/unittest/libphobos2-ut.so(_D3std9outbuffer16__unittestL378_4FNfZv+0xa2)[0x7f8ead4d6d4a]
generated/linux/debug/64/unittest/libphobos2-ut.so(_D3std9outbuffer9__modtestFZv+0x13)[0x7f8ead4e41c3]
generated/linux/debug/64/unittest/test_runner(+0x16bb)[0x55e8458d26bb]
generated/linux/debug/64/unittest/test_runner(+0x160a)[0x55e8458d260a]
generated/linux/debug/64/unittest/test_runner(+0x1450)[0x55e8458d2450]
generated/linux/debug/64/unittest/libphobos2-ut.so(runModuleUnitTests+0xbc)[0x7f8eaf05981c]
generated/linux/debug/64/unittest/libphobos2-ut.so(_D2rt6dmain211_d_run_mainUiPPaPUAAaZiZ6runAllMFZv+0x1e)[0x7f8eaf082f2e]
generated/linux/debug/64/unittest/libphobos2-ut.so(_D2rt6dmain211_d_run_mainUiPPaPUAAaZiZ7tryExecMFMDFZvZv+0x34)[0x7f8eaf082ebc]
generated/linux/debug/64/unittest/libphobos2-ut.so(_d_run_main+0x381)[0x7f8eaf082e29]
generated/linux/debug/64/unittest/test_runner(+0x1aa6)[0x55e8458d2aa6]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1)[0x7f8ea94891c1]
generated/linux/debug/64/unittest/test_runner(+0x121a)[0x55e8458d221a]
posix.mak:376: recipe for target 'unittest/std/outbuffer.run' failed
make: *** [unittest/std/outbuffer.run] Segmentation fault (core dumped)

So there still is a little work to do.
I am not really sure how/where to get started with either of these two bugs.

dkgroot · 2018-02-26T13:59:29Z

@ibuclaw Are you able to pass the druntime/phobos 'dmd-cxx' branch unittests using gdc ?

ibuclaw · 2018-02-26T17:48:02Z

I can report back in a couple hours on that. Upstream gdc itself mirrors the 2.076.1 branch - plus some platform updates.

ibuclaw · 2018-02-27T00:13:48Z

@dkgroot - Actually, I don't think I can say because there's so many things in dmd's rt modules that just don't work with gdc.

Judging from this stack trace you gave.

generated/linux/debug/64/unittest/libphobos2-ut.so(_D4core4stdc6stdarg7va_copyFNbJPS4core4stdc6stdarg13__va_list_tagPS4core4stdc6stdarg13__va_list_tagPvZv+0x2d)[0x7f8eaf063575]
generated/linux/debug/64/unittest/libphobos2-ut.so(_D3std9outbuffer9OutBuffer7vprintfMFNbNeAyaPS4core4stdc6stdarg13__va_list_tagZv+0xca)[0x7f8ead4d67ba]
generated/linux/debug/64/unittest/libphobos2-ut.so(_D3std9outbuffer9OutBuffer6printfMFNeAyaYv+0xa0)[0x7f8ead4d6950]

Problems with va_list tend to point towards dmd's backend code generator.

ibuclaw · 2018-02-27T00:15:26Z

I can report back in a couple hours on that. Upstream gdc itself mirrors the 2.076.1 branch - plus some platform updates.

The version of druntime/phobos that is in gdc's tree does pass all unittests in CI.

https://semaphoreci.com/d-programming-gdc/gdc/branches/master/builds/512

dkgroot · 2018-02-28T19:50:59Z

@wilzbach Have you been able to run the dmd-cxx unittests and/or found the cause for the va_args issue ? I have been looking, but cannot find the cause.

ibuclaw · 2018-03-03T10:48:39Z

Ah, bugger. Looks like the assert failure in the auto-tester is issue 15149. But there's a typo in one of the conditions.

PR here for testing: D-Programming-GDC/gdc#629

ibuclaw · 2018-03-03T12:33:42Z

make[1]: Entering directory '/data/develop/dmd/dmd-cxx/druntime/test/exceptions'
/data/develop/dmd/dmd-cxx/dmd/src/dmd -m64 -w -I../../src -I../../import -Isrc -defaultlib= -debuglib= -dip1000 -fPIC -L/data/develop/dmd/dmd-cxx/druntime/generated/linux/debug/64/libdruntime.a -g -debug -ofgenerated/linux/debug/64/unknown_gc src/unknown_gc.d
DMD v2.069-devel-daf285aea-dirty DEBUG
Testing unknown_gc
./generated/linux/debug/64/unknown_gc  2>&1 1>/dev/null | grep -qF "'unknowngc'"
Segmentation fault (core dumped)
Testing line_trace

This segfault happens because va_start does not initialize the argptr.

ibuclaw · 2018-03-03T14:18:05Z

With all referenced PRs merged in, I think the auto-tester should be able to get as far as passing the druntime and phobos unittests.

ibuclaw · 2018-03-03T23:53:02Z

Windows (dmc) has a very interesting error message:
https://auto-tester.puremagic.com/show-run.ghtml?projectid=17&runid=3057204&isPull=true

case STCreturn | STCref:   result = SRReturnRef;   break;    <--
case STCreturn | STCscope: result = SRReturnScope; break;    <--
case STCref    | STCscope: result = SRRefScope;    break;
case STCreturn | STCref | STCscope:    <--

Looks like there's a bug in dmc to me, as if it overflows on STCreturn, and so doesn't see the value.

…UILD)/$(MODEL)

ibuclaw · 2018-03-04T17:52:05Z

Rebased as other PRs have been merged.

ibuclaw

Druntime and Phobos builds in the auto-tester.

Testsuite fails, but then again that's fine, as I don't think any attempt has been made to sync the testsuite yet.

ibuclaw · 2018-03-04T18:00:13Z

@wilzbach - Let's merge so that it isn't sitting around.

wilzbach force-pushed the auto-tester-dmd-cxx branch from 6c1ec1a to dc71e70 Compare February 25, 2018 00:35

wilzbach added the WIP Work In Progress - not ready for review or pulling label Feb 25, 2018

wilzbach mentioned this pull request Feb 25, 2018

[dmd-cxx] Temporarily disable checkwhitespace to get auto-tester to build DMD's testsuite dlang/phobos#6220

Closed

ibuclaw mentioned this pull request Feb 25, 2018

Add initial codeowners file to C++ port #7955

Merged

ibuclaw added the C++ Port label Feb 25, 2018

ibuclaw self-assigned this Feb 25, 2018

[dmd-cxx]: Fix the auto-tester and copy dmd to $(GENERATED)/$(OS)/$(B…

0532a2d

…UILD)/$(MODEL)

ibuclaw force-pushed the auto-tester-dmd-cxx branch from dc71e70 to 0532a2d Compare March 4, 2018 17:51

wilzbach requested a review from ibuclaw as a code owner March 4, 2018 17:51

ibuclaw approved these changes Mar 4, 2018

View reviewed changes

ibuclaw merged commit 2889afc into dlang:dmd-cxx Mar 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dmd-cxx]: Fix the auto-tester and copy dmd to $(GENERATED)/$(OS)/$(BUILD)/$(MODEL) #7953

[dmd-cxx]: Fix the auto-tester and copy dmd to $(GENERATED)/$(OS)/$(BUILD)/$(MODEL) #7953

wilzbach commented Feb 24, 2018

dlang-bot commented Feb 24, 2018

wilzbach commented Feb 25, 2018 •

edited

dkgroot commented Feb 26, 2018 •

edited

dkgroot commented Feb 26, 2018

ibuclaw commented Feb 26, 2018

ibuclaw commented Feb 27, 2018

ibuclaw commented Feb 27, 2018

dkgroot commented Feb 28, 2018

ibuclaw commented Mar 3, 2018 •

edited

ibuclaw commented Mar 3, 2018

ibuclaw commented Mar 3, 2018

ibuclaw commented Mar 3, 2018

ibuclaw commented Mar 4, 2018

ibuclaw left a comment

ibuclaw commented Mar 4, 2018

[dmd-cxx]: Fix the auto-tester and copy dmd to $(GENERATED)/$(OS)/$(BUILD)/$(MODEL) #7953

[dmd-cxx]: Fix the auto-tester and copy dmd to $(GENERATED)/$(OS)/$(BUILD)/$(MODEL) #7953

Conversation

wilzbach commented Feb 24, 2018

dlang-bot commented Feb 24, 2018

Bugzilla references

wilzbach commented Feb 25, 2018 • edited

dkgroot commented Feb 26, 2018 • edited

dkgroot commented Feb 26, 2018

ibuclaw commented Feb 26, 2018

ibuclaw commented Feb 27, 2018

ibuclaw commented Feb 27, 2018

dkgroot commented Feb 28, 2018

ibuclaw commented Mar 3, 2018 • edited

ibuclaw commented Mar 3, 2018

ibuclaw commented Mar 3, 2018

ibuclaw commented Mar 3, 2018

ibuclaw commented Mar 4, 2018

ibuclaw left a comment

Choose a reason for hiding this comment

ibuclaw commented Mar 4, 2018

wilzbach commented Feb 25, 2018 •

edited

dkgroot commented Feb 26, 2018 •

edited

ibuclaw commented Mar 3, 2018 •

edited