cleaner fix for Issue 18480 - dmd hangs with self-alias declaration #7954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @MartinNowak! Bugzilla references
|
|
FYI @timotheecour and @RazvanN7, also see #7930 (comment). |
- fixed by detecting `alias sym = sym;` during semantic - small adoption of assertion in mostVisibleOverload to deal with alias error expression (type = Type.terror) in overload
MartinNowak
force-pushed
the
fix18480
branch
from
ad3172d
to
414ae99
Compare
JinShil
approved these changes
Feb 25, 2018
|
Thanks, @MartinNowak |
ibuclaw
approved these changes
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alias sym = sym;during semanticalias error expression (type = Type.terror) in overload
see #7930 for previous workaround