Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 18553 - Allow mov reg64,crn and mov crn,reg64 #8017

Merged
merged 2 commits into from Mar 22, 2018

Conversation

LemonBoy
Copy link
Contributor

Also add support for reading/writing the CR8 register on x64.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @LemonBoy! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
18553 normal Inline assembler: CR2, CR3 control registers not available in 64-bit code

Also add support for reading/writing the CR8 register on x64.
@ghost
Copy link

ghost commented Mar 13, 2018

How about RIP ? (https://issues.dlang.org/show_bug.cgi?id=17617)

@JinShil
Copy link
Contributor

JinShil commented Mar 18, 2018

This is one of those PRs for which @WalterBright is uniquely qualified to review. Assigning to him.

@WalterBright
Copy link
Member

When creating a PR to fix a bugzilla issue, please post a link to the PR in the issue. This is so that someone browsing bug reports will know if and where a PR for it is.

{
asm
{
mov RAX, CR0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to test/runnable/iasm64.d instead, as those include checks that the correct opcodes are emitted. Just seeing if it compiles is insufficient. You can see these tests for these instructions in 32 bit mode in test/runnable/iasm.d.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You can delete this file now :-)

@JinShil
Copy link
Contributor

JinShil commented Mar 22, 2018

Closing and reopening to wake up Semaphore CI.

@JinShil JinShil closed this Mar 22, 2018
@JinShil JinShil reopened this Mar 22, 2018
@dlang-bot dlang-bot merged commit a73766d into dlang:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants