New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 18553 - Allow mov reg64,crn and mov crn,reg64 #8017
Conversation
Thanks for your pull request and interest in making D better, @LemonBoy! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
Also add support for reading/writing the CR8 register on x64.
How about RIP ? (https://issues.dlang.org/show_bug.cgi?id=17617) |
This is one of those PRs for which @WalterBright is uniquely qualified to review. Assigning to him. |
When creating a PR to fix a bugzilla issue, please post a link to the PR in the issue. This is so that someone browsing bug reports will know if and where a PR for it is. |
test/compilable/iasm64.d
Outdated
{ | ||
asm | ||
{ | ||
mov RAX, CR0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to test/runnable/iasm64.d instead, as those include checks that the correct opcodes are emitted. Just seeing if it compiles is insufficient. You can see these tests for these instructions in 32 bit mode in test/runnable/iasm.d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! You can delete this file now :-)
Closing and reopening to wake up Semaphore CI. |
Also add support for reading/writing the CR8 register on x64.