fix Issue 18484 - [dip1000] Subtype allows reference to escape with i… #8036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
| int* test2() | ||
| { | ||
| return S().bar(); // error | ||
| } |
There was a problem hiding this comment.
This code is not marked as @safe, how come it errors out ?
There was a problem hiding this comment.
Because it's obviously wrong. Even unsafe code gets some checks!
There was a problem hiding this comment.
So far, DIP1000 only affected @safe code (or at least that was the state intention). It looks like this change also change behavior in non-@safe code, which is very odd to me.
JinShil
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mplicit casting