Fix Issue 16317 - Wrong binop evaluation/load order when optimizing

[LemonBoy]

Nothing to see here (for now), move along.
Let's see if 16317 is gone for good.

[dlang-bot]

Thanks for your pull request and interest in making D better, @LemonBoy! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	16317	critical	Wrong binop evaluation/load order when optimizing

[WalterBright]

Please use the format: "fix Issue NNNN ..." for PR subjects that fix Issue NNNN. This triggers the dlangbot to do the right thing and connect it. It's also necessary to insert the link to this PR as a comment on the bugzilla issue. (I have already done it for this PR.) All this is necessary for cross referencing purposes.

[WalterBright]

https://issues.dlang.org/show_bug.cgi?id=16317

[wilzbach]

(FYI @LemonBoy: @dlang-bot looks at the commit message - not the title)

[LemonBoy]

@WalterBright as you may have noticed there's no description of the problem nor of the solution implemented, there's no proper commit message but there's a suggestive "Nothing to see here (for now), move along." in the first message.
I only needed to run this commit trough the testing pipeline to see whether my assumptions about the code are correct or not, I'll follow up with a proper patch and commit message soon.

[WalterBright]

I only needed to run this commit trough the testing pipeline to see whether my assumptions about the code are correct or not, I'll follow up with a proper patch and commit message soon.

Thanks for the explanation (and the work!). In general, if a PR is not ready for review, put WIP in the title and we won't bother you until it's ready :-)

[RazvanN7]

@LemonBoy what's the status on this?

[RazvanN7]

@LemonBoy ping

[RazvanN7]

I will close this for now as it appears that the purpose of it was to test some assumptions. @LemonBoy feel free to reopen if you will start working again on it.