Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: more use of ctorflow #8113

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Conversation

WalterBright
Copy link
Member

Move more implementation details of CtorFlow into ctorflow.d

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8113"

@WalterBright WalterBright added the Refactoring No semantic changes to code label Apr 2, 2018
@wilzbach wilzbach added this to In progress in Modernize DMD via automation Apr 2, 2018
Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@wilzbach
Copy link
Member

wilzbach commented Apr 2, 2018

FYI: auto-merge won't work if one CI fails and Jenkins is currently "permanently" failing - dlang/ci#190

callSuper |= csx;
foreach (ref u; fieldinit)
u |= csx;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -9115,20 +9115,16 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor
ec = resolveProperties(sc, ec);
ec = ec.toBoolean(sc);

const cs0 = sc.ctorflow.callSuper;
auto fi0 = sc.ctorflow.saveFieldInit();
CtorFlow ctorflow_root = sc.ctorflow.clone();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WalterBright WalterBright merged commit 44d849e into dlang:master Apr 2, 2018
Modernize DMD automation moved this from In progress to Done Apr 2, 2018
@WalterBright WalterBright deleted the ctorflow2 branch April 2, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Refactoring No semantic changes to code
Projects
No open projects
Modernize DMD
  
Done
4 participants