refactor: more use of ctorflow #8113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8113" |
|
FYI: auto-merge won't work if one CI fails and Jenkins is currently "permanently" failing - dlang/ci#190 |
wilzbach
reviewed
Apr 2, 2018
| callSuper |= csx; | ||
| foreach (ref u; fieldinit) | ||
| u |= csx; | ||
| } |
| @@ -9115,20 +9115,16 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor | |||
| ec = resolveProperties(sc, ec); | |||
| ec = ec.toBoolean(sc); | |||
|
|
|||
| const cs0 = sc.ctorflow.callSuper; | |||
| auto fi0 = sc.ctorflow.saveFieldInit(); | |||
| CtorFlow ctorflow_root = sc.ctorflow.clone(); | |||
There was a problem hiding this comment.
Isn't DStyle is camelCase?
https://dlang.org/dstyle.html#naming_general
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move more implementation details of
CtorFlowintoctorflow.d