-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: more use of ctorflow #8113
Conversation
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8113" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet
FYI: auto-merge won't work if one CI fails and Jenkins is currently "permanently" failing - dlang/ci#190 |
callSuper |= csx; | ||
foreach (ref u; fieldinit) | ||
u |= csx; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -9115,20 +9115,16 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor | |||
ec = resolveProperties(sc, ec); | |||
ec = ec.toBoolean(sc); | |||
|
|||
const cs0 = sc.ctorflow.callSuper; | |||
auto fi0 = sc.ctorflow.saveFieldInit(); | |||
CtorFlow ctorflow_root = sc.ctorflow.clone(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't DStyle is camelCase?
https://dlang.org/dstyle.html#naming_general
Move more implementation details of
CtorFlow
intoctorflow.d