fix Issue 18708 - Flow analysis in constructors not done correctly fo… #8118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8118" |
WalterBright
force-pushed
the
fix18708
branch
3 times, most recently
from
190e73f
to
e666061
Compare
jacob-carlborg
suggested changes
Apr 3, 2018
src/dmd/ctorflow.d
Outdated
| /****************************** | ||
| * OR CSX bits to `this` | ||
| * Params: | ||
| * from = bits to OR in |
There was a problem hiding this comment.
The name of the parameter is ctorflow.
| @@ -0,0 +1,64 @@ | |||
| /* TEST_OUTPUT: | |||
| --- | |||
| fail_compilation/test18708.d(24): Error: one path skips field `s` | |||
There was a problem hiding this comment.
Can the missing path be included in the error message?
There was a problem hiding this comment.
Changing error messages is beyond the scope of this PR.
jacob-carlborg
suggested changes
Apr 3, 2018
| ctorflow.freeFieldinit(); | ||
| } | ||
| } | ||
| enclosing.ctorflow.OR(ctorflow); |
There was a problem hiding this comment.
Indentention looks inconsistent.
There was a problem hiding this comment.
It isn't. This line is in an if block.
There was a problem hiding this comment.
Ok, I’m a bit limited here on my phone.
jacob-carlborg
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r if, ||, &&