New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: merge redundant super() and this() code #8122
Conversation
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8122" |
bdc0f9c
to
8febede
Compare
8febede
to
5e6a3d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+25 −48 👍
|
||
if (!exp.f || exp.f.errors) | ||
return setError(); | ||
|
||
checkFunctionAttributes(exp, sc, exp.f); | ||
//checkAccess(loc, sc, NULL, f); // necessary? | ||
checkAccess(exp.loc, sc, null, exp.f); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check should have been in both sections of code, not just one.
} | ||
|
||
if (!sc.intypeof) | ||
if (!sc.intypeof /*&& !(sc.ctorflow.callSuper & CSX.halt)*/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing that test was a bug introduced by #8100
I plan on doing a proper fix after this is pulled (because then I don't have to do rebases).
PR looks good. Why is Jenkins failing?
|
Unrelated -> dlang/ci#193 |
No description provided.