Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 18130 - ICE on zero-length out array parameter #8127

Merged
merged 1 commit into from Apr 5, 2018

Conversation

wilzbach
Copy link
Member

@wilzbach wilzbach commented Apr 4, 2018

Let's better error in such cases (instead of throwing a segfault to the user)?

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 4, 2018

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close Bugzilla Severity Description
18130 critical ICE on zero-length out array parameter

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8127"

@wilzbach wilzbach added the WIP Work In Progress - not ready for review or pulling label Apr 4, 2018
@wilzbach wilzbach changed the title Fix Issue 18130 - ICE on zero-length out array parameter [WIP] Fix Issue 18130 - ICE on zero-length out array parameter Apr 4, 2018
@wilzbach wilzbach removed the WIP Work In Progress - not ready for review or pulling label Apr 4, 2018
@wilzbach wilzbach changed the title [WIP] Fix Issue 18130 - ICE on zero-length out array parameter Fix Issue 18130 - ICE on zero-length out array parameter Apr 4, 2018
@dlang-bot dlang-bot merged commit 6957a6a into dlang:master Apr 5, 2018
@wilzbach wilzbach deleted the fix-18130 branch July 1, 2018 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants