New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade gdc to gdc-8 #8431
Upgrade gdc to gdc-8 #8431
Conversation
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8431" |
fcf7bc9
to
2e1cbd3
Compare
5e2e6e8
to
1ac2948
Compare
282dd93
to
12a509d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's pretty ugly, but if it works...
ci.sh
Outdated
mkdir -p ~/dlang/gdc-8 | ||
sudo ln -s /usr/bin/gdc-8 /usr/bin/gdc | ||
echo "deactivate(){ echo;}" > ~/dlang/gdc-8/activate | ||
sed -i "s/-vtls //" -i src/posix.mak # gdmd doesn't support -vtls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then add it to the dmd-script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry. gdmd
already supports it and translates it to -fd-vtls
, but it seems like support for it was removed in gdc
- the error is simply:
gdc: error: unrecognized command line option ‘-fd-vtls’
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes that ugly option is gone. And replaced with -ftransition=tls
. Can add a condition to pick one or the other based on the gcc version.
46ab1cb
to
b31521a
Compare
ci.sh
Outdated
mkdir -p ~/dlang/gdc-8 | ||
sudo ln -s /usr/bin/gdc-8 /usr/bin/gdc | ||
echo "deactivate(){ echo;}" > ~/dlang/gdc-8/activate | ||
sed -i "s/-vtls //" -i src/posix.mak # gdc-8 doesn't support -fd-vtls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow that was pretty fast. Thanks a lot!
ci.sh
Outdated
sudo chmod +x /usr/bin/gdmd | ||
# fake install script and create a fake 'activate' script | ||
mkdir -p ~/dlang/gdc-8 | ||
sudo ln -s /usr/bin/gdc-8 /usr/bin/gdc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And lastly, if you save the gdmd script to /usr/bin/gdmd-8
, you wouldn't need this symlink. I guess you'd need to export DMD=gdmd-8
?
@wilzbach - Oops, looks like the compiler was built |
Trying out @ibuclaw's suggestion of using a special Ubuntu PPA.