fix Issue 19201 - func called with argument types (ulong) matches both: __c_long and __c_ulong #8632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h: __c_long and __c_ulong
|
Thanks for your pull request, @ibuclaw! Bugzilla references
|
jacob-carlborg
approved these changes
Aug 28, 2018
|
@jacob-carlborg - I was going to wait for the original author to explain himself. |
Please mention that the next time. Feel free to revert if you want to. |
| tob = to.toBasetype().isTypeBasic(); | ||
| if (tob) | ||
| return implicitConvTo(tob); |
There was a problem hiding this comment.
@ibuclaw These two lines caused regression https://issues.dlang.org/show_bug.cgi?id=19499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any valid reason for the limitation, and gdc builds are broken.