Backport [C++] Allow compiling front-end with strict warnings

[ibuclaw]

Based on #8807.

[dlang-bot]

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "dmd-cxx + dmd#8909"

[ibuclaw]

I didn't check the build, but it seems like you didn't either. ;-)

[thewilsonator]

I waited till semaphore passed.

[ibuclaw]

I don't think it should have passed... :-o

[thewilsonator]

Oh, silly question: why?

[thewilsonator]

I was expecting the autotester, Travis and build kite to fail, which they did. I took semaphore passing as a sign that is was working.

[ibuclaw]

declaration.c:90:13: error: no declaration matches ‘const char* Declaration::kind()’
90 | const char *Declaration::kind()
   |             ^~~~~~~~~~~
In file included from declaration.c:18:
declaration.h:130:17: note: candidate is: ‘virtual const char* Declaration::kind() const’
130 |     const char *kind() const;
    |                 ^~~~
declaration.h:117:7: note: ‘class Declaration’ defined here
117 | class Declaration : public Dsymbol
    |       ^~~~~~~~~~~
declaration.c:191:13: error: no declaration matches ‘const char* TupleDeclaration::kind()’
191 | const char *TupleDeclaration::kind()
    |             ^~~~~~~~~~~~~~~~
In file included from declaration.c:18:
declaration.h:180:17: note: candidate is: ‘virtual const char* TupleDeclaration::kind() const’
180 |     const char *kind() const;
    |                 ^~~~
declaration.h:170:7: note: ‘class TupleDeclaration’ defined here
170 | class TupleDeclaration : public Declaration
    |       ^~~~~~~~~~~~~~~~
declaration.c:578:13: error: no declaration matches ‘const char* AliasDeclaration::kind()’
578 | const char *AliasDeclaration::kind()
    |             ^~~~~~~~~~~~~~~~
In file included from declaration.c:18:
declaration.h:205:17: note: candidate is: ‘virtual const char* AliasDeclaration::kind() const’
205 |     const char *kind() const;
    |                 ^~~~
declaration.h:191:7: note: ‘class AliasDeclaration’ defined here
191 | class AliasDeclaration : public Declaration
    |       ^~~~~~~~~~~~~~~~
declaration.c:708:13: error: no declaration matches ‘const char* OverDeclaration::kind()’
708 | const char *OverDeclaration::kind()
    |             ^~~~~~~~~~~~~~~
In file included from declaration.c:18:
declaration.h:225:17: note: candidate is: ‘virtual const char* OverDeclaration::kind() const’
225 |     const char *kind() const;
    |                 ^~~~
declaration.h:217:7: note: ‘class OverDeclaration’ defined here
217 | class OverDeclaration : public Declaration
    |       ^~~~~~~~~~~~~~~
dclass.c:1392:13: error: no declaration matches ‘const char* ClassDeclaration::kind()’
1392 | const char *ClassDeclaration::kind()
     |             ^~~~~~~~~~~~~~~~
In file included from dclass.c:24:
aggregate.h:309:17: note: candidate is: ‘virtual const char* ClassDeclaration::kind() const’
309 |     const char *kind() const;
    |                 ^~~~
aggregate.h:251:7: note: ‘class ClassDeclaration’ defined here
251 | class ClassDeclaration : public AggregateDeclaration
    |       ^~~~~~~~~~~~~~~~
declaration.c:1773:13: error: no declaration matches ‘const char* VarDeclaration::kind()’
1773 | const char *VarDeclaration::kind()
     |             ^~~~~~~~~~~~~~
In file included from declaration.c:18:
declaration.h:272:17: note: candidate is: ‘virtual const char* VarDeclaration::kind() const’
272 |     const char *kind() const;
    |                 ^~~~
declaration.h:240:7: note: ‘class VarDeclaration’ defined here
240 | class VarDeclaration : public Declaration
    |       ^~~~~~~~~~~~~~
dsymbol.c:296:13: error: no declaration matches ‘const char* Dsymbol::kind()’
296 | const char *Dsymbol::kind()
    |             ^~~~~~~
In file included from dsymbol.c:21:
dsymbol.h:196:25: note: candidate is: ‘virtual const char* Dsymbol::kind() const’
196 |     virtual const char *kind() const;
    |                         ^~~~
In file included from dsymbol.c:21:
dsymbol.h:149:7: note: ‘class Dsymbol’ defined here
149 | class Dsymbol : public RootObject
    |       ^~~~~~~
dclass.c:1830:13: error: no declaration matches ‘const char* InterfaceDeclaration::kind()’
1830 | const char *InterfaceDeclaration::kind()
     |             ^~~~~~~~~~~~~~~~~~~~
In file included from dclass.c:24:
aggregate.h:329:17: note: candidate is: ‘virtual const char* InterfaceDeclaration::kind() const’
329 |     const char *kind() const;
    |                 ^~~~
aggregate.h:320:7: note: ‘class InterfaceDeclaration’ defined here
320 | class InterfaceDeclaration : public ClassDeclaration
    |       ^~~~~~~~~~~~~~~~~~~~
dsymbol.c:924:13: error: no declaration matches ‘const char* OverloadSet::kind()’
924 | const char *OverloadSet::kind()
    |             ^~~~~~~~~~~
In file included from dsymbol.c:21:
dsymbol.h:369:17: note: candidate is: ‘virtual const char* OverloadSet::kind() const’
369 |     const char *kind() const;
    |                 ^~~~
dsymbol.h:361:7: note: ‘class OverloadSet’ defined here
361 | class OverloadSet : public Dsymbol
    |       ^~~~~~~~~~~
dsymbol.c:1276:13: error: no declaration matches ‘const char* ScopeDsymbol::kind()’
1276 | const char *ScopeDsymbol::kind()
     |             ^~~~~~~~~~~~
In file included from dsymbol.c:21:
dsymbol.h:312:17: note: candidate is: ‘virtual const char* ScopeDsymbol::kind() const’
312 |     const char *kind() const;
    |                 ^~~~
dsymbol.h:288:7: note: ‘class ScopeDsymbol’ defined here
288 | class ScopeDsymbol : public Dsymbol
    |       ^~~~~~~~~~~~

And a few more related errors in other files that were touched here. :-)

[thewilsonator]

Note to self, be less trigger happy and don't trust semaphore.

[ibuclaw]

I was expecting the autotester, Travis and build kite to fail, which they did. I took semaphore passing as a sign that is was working.

SemaphoreCI is a no-op for this branch. Travis is the only one to trust here.

[ibuclaw]

I'll rolling up the fix into the next PR...

[thewilsonator]

Duly noted. Thanks!